Jan Cornelissen
Jan Cornelissen
**Description of the Issue** Browsers support the SVG `style` element, see: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/style. Unfortunately SwiftSVG throws an error when trying to parse such files: ``` style is unsupported. For a complete...
The PR for #197
This allows for less version checks and further modernisation of the app. Questions: - Xcode recommends to enable some warnings. Given the age of the code base, I suspect it'll...
e.g. https://staging.api.irail.be/composition/?lang=nl&id=BE.NMBS.L5011 gives this error: ```xml Could not find a station with id 00. ``` But there is an actual result on https://trainmapjs.azureedge.net/data/composition/5011: ```json [{"ptCarFrom":{"id":459,"uicCode":"8844008","fromName":"Géronstère - Géronstère"},"ptCarTo":{"id":1177,"uicCode":"8844008","fromName":"Verviers-C - Verviers-C"},"confirmedBy":"Planning","materialUnits":[{"hasReadingLights":false,"hasFoldingSeats":false,"hasAssistanceButtons":false,"hasToilets":true,"hasTables":true,"hasSecondClassOutlets":false,"hasFirstClassOutlets":false,"hasHeating":true,"hasAirco":false,"typeDescriptionNl":"MR 62-66","tractionType":"AM/MR","pullPushType":"X","diagramServiceNumber":24,"materialDiagram":"MR","isLocoInUse":true,"tractionPosition":1,"positionInComposition":1,"typeDescriptionFr":"AM...
E.g. It's 8:39, a train should have left at 8:29 but has a delay. The delay is then `delay="0"` instead of its actual delay. 
How do we handle official names and their alternatives? e.g. `Brussel-Nationaal-Luchthaven` vs. `Brussels-Airport` or `Amsterdam CS` (old name) vs. `Amsterdam Centraal` (official name).
e.g. https://api.irail.be/connections/?lang=nl&format=json&from=BE.NMBS.008896115&to=BE.NMBS.008833126×el=departure&date=131023&time=1355 ``` {"error":500,"message":"Could not get data: This request failed due to internal errors.. Please report this issue at https://github.com/irail/irail/issues/new"} ``` A few seconds later the error is gone. Happens...
Some `connections` give a bunch of parsing errors. e.g.: https://staging.api.irail.be/connections/?lang=en&format=json&from=BE.NMBS.008833001&to=BE.NMBS.008891702×el=departure ``` Warning: Undefined array key "lead" in /var/www/staging.api.irail.be/src/api/data/NMBS/tools/HafasCommon.php on line 262 Warning: Undefined array key "lead" in /var/www/staging.api.irail.be/src/api/data/NMBS/tools/HafasCommon.php on line...
Can facilities.csv be updated with the new ticket window opening hours? Many thanks!
Happens on staging and production. e.g. https://api.irail.be/v1/connections/?lang=de&to=BE.NMBS.008872009&from=BE.NMBS.008833001 ``` {"code":0,"request-id":"9c09348e-de6f-4751-a35f-42dae66cd099","message":"Call to a member function getLocalizedStationName() on null","previous":null,"at":"\/workspace\/app\/Http\/Responses\/v1\/JourneyPlanningV1Converter.php:68","stack":["#0 \/workspace\/app\/Http\/Responses\/v1\/JourneyPlanningV1Converter.php(68): Irail\\Http\\Responses\\v1\\JourneyPlanningV1Converter::convertDirection(Object(Irail\\Models\\DepartureOrArrival))","#1 \/workspace\/app\/Http\/Responses\/v1\/JourneyPlanningV1Converter.php(38): Irail\\Http\\Responses\\v1\\JourneyPlanningV1Converter::convertDeparture(Object(Irail\\Models\\DepartureOrArrival), Object(Irail\\Models\\JourneyLeg))","#2 \/workspace\/app\/Http\/Responses\/v1\/JourneyPlanningV1Converter.php(31): Irail\\Http\\Responses\\v1\\JourneyPlanningV1Converter::convertJourneyPlan(Object(Irail\\Models\\Journey))","#3 [internal function]: Irail\\Http\\Responses\\v1\\JourneyPlanningV1Converter::Irail\\Http\\Responses\\v1\\{closure}(Object(Irail\\Models\\Journey))","#4 \/workspace\/app\/Http\/Responses\/v1\/JourneyPlanningV1Converter.php(31): array_map(Object(Closure), Array)","#5 \/workspace\/app\/Http\/Controllers\/JourneyPlanningV1Controller.php(37):...