James Murty

Results 71 comments of James Murty

Hi @vdboor thanks for the comments and questions. Sorry for the late reply, the code branch has been in a lot of flux and I wanted to get it (somewhat)...

I should note that with the latest commit to our [integration branch](https://github.com/ixc/django-fluent-pages/tree/reversion_support) we are back to using the official 1.9.3 release of django-reversion, instead of our forked and patched version.

I was struggling with this as well, until I realised that cookies weren't working correctly because I was loading the Shopify site admin in an incognito browser window set to...

Hi @cyruscollier I don't have any more insight into this issue since we "solved" it by switching to the Axios client at the time I opened this issue, but I...

Hi @soraxas this looks like a great feature! Thanks also for cleaning up the `git-common-dir` vs `git-dir` logic. I have pushed some minor changes to get `shellcheck` and `shfmt` linting...

Thanks for the simplified PR. I'm aiming to get a new 2.2.0 release with the fairly urgent OpenSSL v3 fix out to clear the way for this change which I...

Hi @Erotemic I have updated this branch with changes, mostly focussed on getting the existing BATS tests to pass to give us a solid base to work from. I haven't...

Hi @Erotemic I have pushed some updates to get the existing BATS tests to pass for all platforms. With these tests now passing I'm more confident we can progress the...

I think a rekey should regenerate a new `base-salt`. We might need to give the user a way to keep the old base salt if they want to, but this...

We should definitely discourage keeping the same base salt on a rekey. In this case I don't think we need to know whether an existing base salt was randomly or...