James Muehlner

Results 20 comments of James Muehlner

@necouchman If you've made visual changes - would you mind posting a screenshot so we can see what things look like now?

Getting back to this after a few months, and on another read-through it LGTM.

Had you considered allowing either the weekday or time parts of the restrictions to be left out, rather than requiring both? It looks like most of the code would already...

This is all looking pretty reasonable to me - @mike-jumper thoughts?

> The better way is to change the collation used in the queries; however, the challenge, here, is that it requires some knowledge of what collation is being used to...

I tried using `ng serve` to deploy the webapp but it seems to have problems loading a module. Is this expected? ![image](https://github.com/apache/guacamole-client/assets/4633119/804ed2ed-a570-4f50-b394-0cc7245d97b1)

I deployed the app at `/guacamole`/ and most things seem to run well, with a few exceptions (e.g. share link dropdown is broken, broken translations on text input buttons). Super...

This looks reasonable, but I don't see a corresponding guacamole-server PR?

> @jmuehlner, @mike-jumper, would you prefer that I add a comment for each #define or should I leave it like this? To match our guidelines and existing style, each constant...

> @necouchman, @jmuehlner, have you any other comments on this PR? It's looking pretty good to me - though I do wonder if it should be targeted at 1.6.0 -...