jmscreator
jmscreator
[`#define String std::string`](https://github.com/fredilarsen/ReconnectingMqttClient/blob/22f023d13d8bdb9dca5410ace26d3a2dd7daba42/src/ReconnectingMqttClient.h#L8) This causes name conflicts with other libraries. Instead of using #define, instead use an alias: `using String = std::string;`
[`#define SMCBUFSIZE 1000` `uint8_t buffer[SMCBUFSIZE];`](https://github.com/fredilarsen/ReconnectingMqttClient/blob/22f023d13d8bdb9dca5410ace26d3a2dd7daba42/src/ReconnectingMqttClient.h#L15) The buffer allocates 1000 bytes by default, but there is no indication of this anywhere. [`memcpy(&buffer[len], payload, payloadlen);`](https://github.com/fredilarsen/ReconnectingMqttClient/blob/22f023d13d8bdb9dca5410ace26d3a2dd7daba42/src/ReconnectingMqttClient.h#L338) This causes a memory buffer overflow to...