jmsche

Results 42 comments of jmsche

Is there any reason to keep user roles then?

Maybe guikingone/scheduler-bundle would be an option? Or zenstruck's one

Actually in the base Voter class the `$attribute` parameter is typed: https://github.com/symfony/symfony/blob/6.0/src/Symfony/Component/Security/Core/Authorization/Voter/Voter.php#L82

Hello @javiereguiluz, I think this PR can be merged :)

Hi, nice feature :) Could you please move JS to a JS file? IIRC all JS was recently moved from templates to JS files.

@quamis From what I can see it's a code style issue. Run the following command in your terminal to fix it: `vendor/bin/php-cs-fixer fix --config=.php_cs.dist` [Edit] Maybe wait for the https://github.com/box/spout/pull/747...

Related to #218

Hi, It's clearly two different behaviours to add, but IIRC I added them in the same issue as both impact properties. Note: typed properties can be implemented for PHP 7.4...

Hi @stakovicz, One thing I think your package is missing is handling an other prototype name than `__name__`, which can be useful for nested form collections.