Jesse Rosenstock

[Bug]: Incorrect absl::bit_width return type for gcc <= 12

1

### Describe the issue `absl::bit_width(0UL)` should return an `int`. With gcc

S2Cell(S2CellId(p)).Contains(p) requires expansion of (1.125 + eps) * eps

10

`S2Cell(S2CellId(p)).Contains(p) ` should always hold, and there is a test to verify this, but there are counterexamples, causing flaky tests. https://github.com/google/s2geometry/blob/ead4b7a4bfca58067bd473de04f2f9cc5da70250/src/s2/s2cell_test.cc#L494-L500 Is the expansion amount just wrong here? https://github.com/google/s2geometry/blob/ead4b7a4bfca58067bd473de04f2f9cc5da70250/src/s2/s2cell.cc#L299-L306 We...

Optimize S2Cell::GetDistance

5

@ericveach Do you remember what you had in mind with > This could be optimized to be at least 5x faster by pruning the set of possible closest vertex/edge pairs...

big-endian CI

2

To prevent big endian build breakages, we need a runner (e.g. ppc64 or s390x) for the CI workflows. https://github.com/google/s2geometry/issues/469#issue-3589207523 Big endian support is esoteric and low priority, so those wanting...

In https://github.com/google/s2geometry/pull/453#discussion_r2461308787 @smcallis suggests ``` AllowShortCaseLabelsOnASingleLine: true AlignConsecutiveShortCaseStatements: Enabled: true AcrossEmptyLines: true AcrossComments: true AlignCaseColons: false ``` We should see how consistently the existing code is formatted and if this...

Add sanitizer workflows

1

We should be testing with asan/msan/tsan.

Warning options should be the same between bazel, cmake, and google3.

build action broken: can't find cmake

1

https://github.com/google/s2geometry/actions/runs/18241689488/job/51944361674 ``` Run jwlawson/actions-setup-cmake@802fa1a2c4e212495c05bf94dba2704a92a472be with: github-api-token: *** use-32bit: false Using cmake version 4.1.2 /usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/b3f64e3f-b781-41ab-bf8f-4ad5ac4c3346 -f /home/runner/work/_temp/069f9ae4-eb2f-4ae5-bbeb-59255998c3d2 Run actions/cache/restore@0400d5f644dc74513175e3cd8d07132dd4860809 with: path: ./_abseil-cpp/ key: abseil-cpp-20250814.1-Linux-X64-cmake--DCMAKE_CXX_STANDARD=17 -DABSL_PROPAGATE_CXX_STD=ON -DABSL_ENABLE_INSTALL=ON...

Incremental lookup support

6

We have some patches for incremental lookup. Here's what the new `Trie` functions look like: ```c++ // Copyright 2025 Google LLC. // SPDX-License-Identifier: Apache-2.0 // Incrementally looks up the trie...