Jesse Rosenstock

Add SECURITY.md

2

Needed to fix code scanning security policy checks https://github.com/golang/geo/security/code-scanning "Place a security policy file SECURITY.md in the root directory of your repository. This makes it easily discoverable by a vulnerability...

Run CodeQL checks in your CI/CD by following the instructions [here](https://github.com/github/codeql-action#usage). https://github.com/golang/geo/security/code-scanning/7

Integrate the project with OSS-Fuzz by following the instructions [here](https://google.github.io/oss-fuzz/). https://github.com/golang/geo/security/code-scanning/8

add features from blevesearch/geo fork

1

There's a fork at https://github.com/blevesearch/geo with some missing functionality like region term indexer. It would be great to get those merged here. @sreekanth-cb @abhinavdangeti @iulian-gm

C++ removed Shape.id, which doesn't look like it exists in Go. Still, there may be handling of Shape.id that could be synced up with C++. Use of ShapeIndex.idForShape is slow...

Tests should pass a `Rand` around instead of depending on global state. https://github.com/golang/geo/blob/69a8a986ba10df9c6eeab712a5b4adf5740a2567/s2/s2_test.go#L56 C++ was changed to do this a while ago.

We currently build/test with cmake, but not bazel. A bazel workflow should be added, too.

I tried to enable the test workflow for ubuntu 22 and get a failure due to `sincos`. ``` /home/runner/work/s2geometry/s2geometry/src/s2/s1angle_test.cc:139: Failure Expected equality of these values: sin_cos.cos Which is: -0.2[58](https://github.com/google/s2geometry/actions/runs/13603572823/job/38032416706?pr=412#step:8:59)81904510251996 cos(angle)...

s2loop_measures_test GetSignedArea.ErrorAccumulation fails on macOS

1

Unclear if this is a problem with the allowed error threshold or the code. ``` [ RUN ] GetSignedArea.ErrorAccumulation .../s2geometry/src/s2/s2loop_measures_test.cc:286: Failure The difference between expected_area and actual_area is 3.5813685350660762e-11, which...

Use `cibuildwheel` for Python CI

1

I'd recommend using `cibuildwheel` for that but you're right, out of scope of this PR _Originally posted by @zacharyburnett in https://github.com/google/s2geometry/pull/388#discussion_r1828232233_