jmortiger

With the current tokenizer, quoted metatags don't need to be separated from the token that follows them by whitespace, a behavior I kept for the new tokenizer, and extended so...

The new tokenizer and its associated improvements is complete. Next thing is probably revising the test suite to catch any other edge cases I missed, then maybe another profiling pass?

It's all good, I prefer that to letting it grow by keeping dead RuboCop rules in there. It's a good reminder to regen before merging anyways.

Alright, aside from testing and picking an ideal `has_groups?` implementation (& of course expanding the test suite), I don't see much more that can be done. Tomorrow I'll probably just...

I'll only be pushing merges, doc comments & expansions to the test suite (specifically `test/unit/tag_query_test.rb`) for the next few days unless I find a bug through that, in which case...

No objections at all! The only notes I'd have is * I'm split on removing the `TagQuery::SETTINGS`, `ElasticPostQueryBuilder::GLOBAL_DELETED_FILTER`, & `ElasticPostQueryBuilder::ERROR_ON_DEPTH_EXCEEDED` constants (assuming the currently selected settings are ok); it might...

That makes sense; I've toggled off that flag.

I'll be leaving this as is for now to remove the need for extra testing.

Glad to hear it! Thanks for taking the time to review & merge it, I'm sure there's never enough to go around.

I get the same; full error is ``` NOTE: RubyProf.measure_mode= is deprecated; use RubyProf::Profile#measure_mode= instead. It will be removed on or after 2023-06. RubyProf.measure_mode= called from /usr/local/bundle/bundler/gems/rails-perftest-00adba5ca81d/lib/rails/perftest/active_support/testing/performance/ruby.rb:125 ``` [Link to...