jmondi

> > The first and probably most evident one is the pre-allocation of the video device numbers. > > https://github.com/raspberrypi/linux/blob/rpi-6.1.y/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c#L27 > > This is not gonna fly in mainline most...

I've now noticed there is no uapi file for the back end config buffer. I presume it's in libpisp ? I guess we need one for kernel, and I'm wondering...

> The UAPI file is effectively here: https://github.com/raspberrypi/linux/blob/rpi-6.1.y/drivers/media/platform/raspberrypi/pisp_be/pisp_be_config.h > > This file is duplicated in libpisp/libcamera. I'll move it to uapi then

`V4L2_PIX_FMT_RPI_BE` is said to be `/* Opaque BE format for HW verification. */` Does it need to be upstreamed ?

Also I recall that there was a documentation draft for the RAW compressed formats but I don't seem to be able to find it. Any pointer ?

> > `V4L2_PIX_FMT_RPI_BE` is said to be `/* Opaque BE format for HW verification. */` > > Does it need to be upstreamed ? > > Ideally yes if it...

> @jmondi this is something we should put into the next revision of your upstream driver. I'll take this in and take the occasion to send a new version. If...

This last push adds documentation for the image formats and the isp and breaks the uapi header out from the driver directory. The only missing part is the documentation of...

> Ah, ~perhaps~ this is the fix: > Why I don't see it ? ` Linux version 6.7.0+ (jmondi@fedora) (aarch64-linux-gnu-gcc (GCC) 13.2.1 20230728 (Red Hat Cross 13.2.1-1), GNU ld version...

> Ah, ~perhaps~ this is the fix: > > ```c > diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > index 07f0fb8aa85c..6e88491b20ba 100644 > --- a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > @@ -265,7 +265,7 @@...