Results 264 comments of José Luis Millán

For some reason meson (ninja) is creating a `compile_commands.json` file containing the compilation information for every target in `meson.build`. That includes targets which DO use `-fsanitize=address` flag. It seems that...

I'm finally installing the [libclang-rt-21-dev](https://github.com/versatica/mediasoup/commit/c3f0d64abcd734a2e4dbc2a425dbac0b21561688) rather than mangling the `compile_commands.json` file. > actually it's only necessary to generate the compile_commands.json file, you don't have to compile anything. With a meson...

I've also tried with "clang_tidy_checks: 'misc-const-correctness'" solely and the result is the same: [zero warnings](https://github.com/versatica/mediasoup/actions/runs/19542267721/job/55951556798#step:4:462). The changes in `SvcConsumer.cpp` are the following, which obviously should trigger the warnings, as they...

It's related to `--line-filter` indeed. `clang-tidy-review` adds the real path of the file, which is not detected by `clang-tidy`. As per the my tests you must put there either the...

So if I create the `compile_commands.json` in the root dir it should work.

> the line filter requiring only the filename and not a path just doesn't feel like correct behaviour. It allows either the **filename** or the path **as it comes in...

Of course meson won't let you build on a folder that already has content: `ERROR: Source and build directories must not be the same. Create a pristine build directory.`

In a way, it makes sense that `clang-tidy` tries to find files where `compile_commands.json` indicate and otherwise just look by name. I think that the correct approach for `clang-tidy-review` here...

Just a comment, I still have no way to have this action working on my repo :-(

Indeed it seems to work locally (with `act`) building in `build` folder from the root directory and setting it as the `build_dir`. Changes made in the .yaml: ```diff diff --git...