jmhon08 comments

Repositories
Issues
Comments

Results 2 comments of


                                            jmhon08

How to set component_span with Rack middleware?

I'm not exactly clear how to use the change in https://github.com/openzipkin/zipkin-api/pull/42/files to now get the route in the span name. How do I use HTTP_ROUTE in zipkin-ruby? Do I still...

How to set component_span with Rack middleware?

OK I think I figured it out https://github.com/openzipkin/zipkin-ruby/pull/122/files. This looks good for our Rails app. Can you please review? ![screen shot 2018-06-19 at 6 17 06 pm](https://user-images.githubusercontent.com/1102790/41632117-37242282-73ed-11e8-89ac-2d52e1a7951f.png)