Jörg-Michael Grassau
Jörg-Michael Grassau
Hi robinbaeurle, yes, I remember a similar request in the Inner-Source phase of ABAP cleaner. It would certainly be technically possible, but as Josh pointed out, is it desirable (explicitly...
Hi Jan, thanks for the idea! We'd have to take a close look on exactly which cases of REPLACE could be replaced with replace() :-), but the hint in the...
Hi openPhiL, nice one, happy to add an option for this :-) – but maybe on rule "Separate methods and classes with empty lines", which is concerned with empty lines...
Hi Vlad, yes, I've seen this behavior sometimes, too. Actually, the styleguide discourages comments at line end altogether ([Put comments before the statement they relate to](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to)), but admittedly, IMHO, they...
Hi Benjamin, yes, that would indeed be a nice cleanup rule! The idea was already raised in #36 (point 10), but I think this is worth a dedicated issue! Kind...
Hi Benjamin, this idea … ```ABAP DATA(message) = `Return code ` && code && ` with message ` && text. ``` > Could be converted to: ```ABAP DATA(message) = |Return...
Hi ConjuringCoffee, you're right, this option only has an effect if combined with:  It then means: If the concatenation contains a text literal, always put ```|...|``` around it, even...
Hi ConjuringCoffee, if you use "Embed … if result is _shorter_" (but NOT equal), then nothing is changed:  So, "_Always_ convert text literals …" really has this notion of...
Hi Xexer and Fabian, nice idea! I agree that this should rather be an opt-in rule (i.e. deactivated by default); but if the style guide says "Prefer INSERT INTO TABLE...
Hi Josh, great, that sounds very promising for multiple new cleanup rules! We'd have to check about limitations for automation in the individual cases, of course, but looking forward to...