Jörg-Michael Grassau

Results 139 comments of Jörg-Michael Grassau

Hi ConjuringCoffee, the plug-in is currently indeed unsigned, so unfortunately, this is expected behavior as of now. We are investigating how to best change that… Kind regards, Jörg-Michael

Hi sandraros, good idea – this will be added to the installation instructions with the next release! ![image](https://github.com/SAP/abap-cleaner/assets/79639298/e2a0675f-6c0c-427b-91dd-cb487904a943) Kind regards, Jörg-Michael

Hi ConjuringCoffee, this would of course make the comparison with previous revisions rather difficult to read (so, surely an opt-in rule that is deactivated by default), but it does make...

Hi ConjuringCoffee, ah, you're right, with "ABAP Compare (Sorted Class Methods)" this wouldn't be such an issue, and I think this comparison option is available in ADT regardless of the...

Hi Benedikt, just to be sure, you would mean for such a flag to be part of the main window's "Cleanup Settings", i.e. on a similar level as "Restrict rules...

Hi ConjuringCoffee, that sounds like a good starting point to me, because as far as I know, FOR TESTING methods are always private, so the question of how their "vertical...

Hi ConjuringCoffee, yes, that's a good idea – and also explicitly demanded by the styleguide: [No more than one statement per line](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#no-more-than-one-statement-per-line)! Kind regards, Jörg-Michael

Hi, that's a good point, thanks! Will check whether this can be enhanced accordingly. Kind regards, Jörg-Michael

Hi ConjuringCoffee, that makes sense, you wouldn't want to type `````` manually or to copy/paste it from another place. However, let me first try to find out why the Quick...

Hi ConjuringCoffee and Josh, yeah, I do agree that the layout doesn't look great here, and actually that's one of the reasons why I personally prefer ![image](https://github.com/SAP/abap-cleaner/assets/79639298/a086e8f0-a94e-4c5f-94ae-feeba2e624fa) which leads to:...