Jack Geraghty

Results 10 comments of Jack Geraghty

> @jmg049 thanks for the suggestions! Would you like to send a draft PR with implementing that? Hey, sure, it might take some time though unfortunately(if only contributing was my...

Yes it definitely looks better. No doubt about it. I'm still not a huge fan of always having the epoch info there and more specifically that it's tied to the...

I'm preparing a PR for this right now. I have the implementation ready and just need to focus on some tests, docs and where exactly to put the functionality. I...

> Is this **only** for NumPy compatibility? Yes it is. So the motivation for adding the angle functionality was because I was working on porting some Python and Numpy code...

I have created a new commit which should address your concerns. There is no longer the HasAngleF64 trait and no more type promotion to f64. The user controls the float...

I agree with the reasoning for keeping everything in radians (option 3). The original reference point for this PR was the NumPy function, which included a deg parameter, but I...

And I am also aware that adding such guidelines is not an easy task and relies on a lot of "in-house" knowledge that may not be easily surfaced. But just...

No problem at all. I really appreciate the engagement. I love the crate, it’s essential, and I’ve recently been using it more heavily as the core data structure in my...

I have pushed the next commit which hopefully addresses the comments. If not just let me know.

Are there any more concerns with this? I would love to access this via the crates.io version of the crate rather than point my Cargo.toml to a forked repo. Thanks