John Chilton comments

Results 150 comments of


                                            John Chilton

Add when_empty attribute to tool outputs that can 'hide' or 'delete' …

> Presumably, you might want to also apply this flag to the contents (datasets) within the collection, but that would happen to the dataset OutputObjects, not the collection OutputObject. There...

Add when_empty attribute to tool outputs that can 'hide' or 'delete' …

Delay because of existing comments.

Get environment variables for data_source_async tools

> Let me know if it's ok or if it too specific to my needs. If not I can close these two PR. I think it might be okay -...

[RFC] Link datasets w/ extension into working directory

> should we do the symlinking on the framework level at all ? Yes, absolutely yes. > should we do this by default (as in this PR) ? Probably not...

Allow type_source to reference a collection input in a repeat

https://github.com/galaxyproject/galaxy/pull/7885 will hopefully fix this failing integration test, sorry about that.

[WIP] Migrate htcondor runner to use the python htcondor bindings

Wheel size could be addressed a bit by conditionally loading the dependency - like Kubernetes does I believe. If there are open questions and you're not sure this will be...

[WIP] Migrate htcondor runner to use the python htcondor bindings

Pushing milestone - seems like there is a plan there we just need someone to implement it. If it gets done before the freeze we can just readjust the milestone.

Dynamic post-processing actions

Clever with the docstring - I like that - looks good to me! I also like the client side piece is a light touch - this basically doesn't constrain frontend...

Dynamic post-processing actions

Rerunning the qunit tests - those sometimes fail randomly but it looked like it might be related to the PR.

Dynamic post-processing actions

@galaxybot test this