galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Dynamic post-processing actions

Open anatskiy opened this issue 7 years ago • 10 comments

The PR adds a new feature by executing a custom Python function after a workflow run. In this example, Galaxy sends a simple desktop notification:

screenshot from 2018-02-01 20-41-13

screenshot from 2018-02-01 20-42-45

All credits go to @bgruening, I just adapted the 3-year-old feature to the latest dev.

anatskiy avatar Feb 01 '18 20:02 anatskiy

@dannon do you remember our discussion about this extension? 3 years ago we were able to control a robot depending on the output of a workflow, sample new data and resubmit a workflow. A feedback loop was with this possible :)

https://github.com/bgruening/hackathonfr

bgruening avatar Feb 05 '18 18:02 bgruening

@martenson for some reason I'm unable to revert the two remaining static files. The error is:

❯ git checkout e591288cadf5af3acb0700f01cbac1188f07abb1 static/scripts/libs/bibtex.js           
error: pathspec 'static/scripts/libs/bibtex.js' did not match any file(s) known to git.

anatskiy avatar Feb 08 '18 11:02 anatskiy

@anatskiy I will have a look. You also need to generate the sample config (and commit it) using the makefile target I linked.

Thanks for the adjustments!

edit: I think you can remove those static files in another commit, and then squash it using rebase.

martenson avatar Feb 08 '18 22:02 martenson

@martenson what command generates the config file?

anatskiy avatar Feb 11 '18 20:02 anatskiy

@anatskiy make config-rebuild - sorry for including wrong link previously

martenson avatar Feb 11 '18 21:02 martenson

Clever with the docstring - I like that - looks good to me! I also like the client side piece is a light touch - this basically doesn't constrain frontend development at all. Thanks!

jmchilton avatar Mar 20 '18 15:03 jmchilton

Rerunning the qunit tests - those sometimes fail randomly but it looked like it might be related to the PR.

jmchilton avatar Mar 20 '18 16:03 jmchilton

@galaxybot test this

jmchilton avatar Mar 20 '18 16:03 jmchilton

Thanks all for the review. @RJMW any comments from your side?

bgruening avatar Mar 20 '18 18:03 bgruening

I think the qunit tests are failing because of changes in client/galaxy/scripts/mvc/workflow/workflow-forms.js. Sorry to pile on @anatskiy.

jmchilton avatar Mar 20 '18 18:03 jmchilton