galaxy
galaxy copied to clipboard
Dynamic post-processing actions
The PR adds a new feature by executing a custom Python function after a workflow run. In this example, Galaxy sends a simple desktop notification:
All credits go to @bgruening, I just adapted the 3-year-old feature to the latest dev.
@dannon do you remember our discussion about this extension? 3 years ago we were able to control a robot depending on the output of a workflow, sample new data and resubmit a workflow. A feedback loop was with this possible :)
https://github.com/bgruening/hackathonfr
@martenson for some reason I'm unable to revert the two remaining static files. The error is:
❯ git checkout e591288cadf5af3acb0700f01cbac1188f07abb1 static/scripts/libs/bibtex.js
error: pathspec 'static/scripts/libs/bibtex.js' did not match any file(s) known to git.
@anatskiy I will have a look. You also need to generate the sample config (and commit it) using the makefile target I linked.
Thanks for the adjustments!
edit: I think you can remove those static files in another commit, and then squash it using rebase.
@martenson what command generates the config file?
@anatskiy make config-rebuild
- sorry for including wrong link previously
Clever with the docstring - I like that - looks good to me! I also like the client side piece is a light touch - this basically doesn't constrain frontend development at all. Thanks!
Rerunning the qunit tests - those sometimes fail randomly but it looked like it might be related to the PR.
@galaxybot test this
Thanks all for the review. @RJMW any comments from your side?
I think the qunit tests are failing because of changes in client/galaxy/scripts/mvc/workflow/workflow-forms.js. Sorry to pile on @anatskiy.