Jackie McDoniel
Jackie McDoniel
@ethanent apologies for the ping, but do you think this could get reviewed and merged up for `phin`?
Ah, shoot, this gets more tricky when it comes to spreading the result. I'll need to play around with this more to see if we can get this extension to...
@Tony133 is makes sense because we use a `...super.forRoot()` and `...super.forRootAsync()` and Typescript isn't able to immediately guarantee that the return of `T | Promise` is **not** going to be...
Looks like this is specifically an issue with the `useMocker` functionality. Using this as the test ```ts describe('TransientService', () => { let transientService: TransientService; beforeEach(async () => { const app:...
> Did you have a chance to investigate this issue @jmcdo29? 🙌 I'll take a look back into it in the morning.. Thanks for bringing it back up :+1:
I believe the original error has to do with trying to auto-mock `INQUIRER` or `REQUEST`, due to what Kamil said about them always being defined. I took our current `integration/auto-mock`...
Please provide a [minimum reproduction repository](https://minimum-reproduction.wtf/) (Git repository/[StackBlitz](https://stackblitz.com/fork/github/nestjs/typescript-starter)/[CodeSandbox](https://codesandbox.io/s/github/nestjs/typescript-starter/tree/master) project). ## [why reproductions are required](https://antfu.me/posts/why-reproductions-are-required)
This is about an 25% increase compared to the original `querystring` library. 727674.83 op/sec vs 913716.89 op/sec (ran the benchmarks on my machine to ensure the same number of requests)...
> the benchmarks and the test suite (which is a replica of node.js querystring module) speak for itself. True, and that's definitely good to see. _I'm_ usually hesitant with brand...
> Somehow `npm i` updates package-lock.json with a massive change list. (I'm using Node 18.8 with npm 8.18) Ah, yeah, we're still using npm 6 with a package-lock.json v1. npm...