Josh McConnell

Results 8 comments of Josh McConnell

@pierresouchay, that's a very good shout, I'll take a look at how I can implement something like that this weekend!

Added this in https://github.com/stusmall/consul-rust/pull/42

Following on from the comment on https://github.com/rust-secure-code/cargo-geiger/issues/16 the remaining usages of the cargo crate are ``` args.rs:252: use cargo::core::Verbosity; args.rs:3:use cargo::core::shell::ColorChoice; args.rs:4:use cargo::{CliResult, Config}; cli.rs:13:use cargo::core::Workspace; cli.rs:14:use cargo::util::{self, important_paths, CargoResult};...

Hi @cds2-stripe, yes this is something we would definitely be keen to push forward with! There are one or two changes we made to our fork which need to be...

Hi @cds2-stripe, I've merged the changes we had been using internally. If there's anything else you'd like me to change, please just let me know! Thanks, Josh

Hi @cds2-stripe, of course! I've just updated the code to resolve the merge conflicts now. Just let me know if there are any more changes you want me to make!

@cds2-stripe - apologies, I've updated, and hopefully fixed the issue with go vet

Fantastic, many thanks @cds2-stripe for the review!