Jannis Mattheis

Results 448 comments of Jannis Mattheis

@KScaesar Only doing this would prevent the feature of using generated methods in custom methods. E.g. https://goverter.jmattheis.de/#/config/extend?id=method-with-converter ```go // goverter:converter // goverter:extend ConvertAnimals type Converter interface { Convert(source Input) Output...

At the time of generation `ConvertDogs` and `ConvertCats` doesn't exist. So the code won't successfully compile. Goverter uses type information for generation and therefore requires that the package with the...

I'm looking for testers of the new style for generation. The version should work well, but they likely will some changes before this will be released. ## Install - `go...

Tags are normally always lowercase, it seems that the rename tag feature doesn't lower case the tag before updating the database.

@pavelpatrin Yes, but it doesn't have a high priority on my to-do list.

Hey @becash, it seems like the beta version has hardcoded the `domain.Arguments` type with a fixed position in the conversion method calls. I find this solution to inflexible, with the...

Types that are context should be inferred from the conversion method signature. ``` // goverter:converter type Converter interface { // goverter:arg:context ctxDB // goverter:arg:context ctxUsers // goverter:arg:source myInput Convert(ctxDB Database,...

Thanks for you feedback. The solution in https://github.com/jmattheis/goverter/issues/77#issuecomment-1892598584 was implemented in [v1.5.0](https://goverter.jmattheis.de/changelog). See [Guide: Input/output formats](https://goverter.jmattheis.de/guide/format). Furthermore, it's possible to generate functions without a struct when defining conversions via an...

> However, there are cases where field names differ beyond the coder's control, like from one protobuf to multiple slightly different "internal" structs, etc. For this goverter has support for...

> we could keep our "source of truth" for mappings as-is and just flip a switch in goverter, if that makes sense. Yeah, in this case I agree. Having tag...