Jannis Mattheis

Results 448 comments of Jannis Mattheis

I'm unsure if this should be implemented, I really like explicitly defining what goverter should do as this makes things more obvious. Adding this, could produce unwanted behavior. F.ex when...

You could do it like this: ```go // goverter:converter // goverter:extend EmptyIfNilString type Converter interface { // goverter:map Address.City City // goverter:map Address.Street Street ConvertPerson(source *Person) *APIPerson } func EmptyIfNilString(s...

Hey Sonia, currently it should be possible to [extend with a custom the converter with a custom method](https://github.com/jmattheis/goverter#extend-with-custom-implementation) and set all the required fields and the missing one. Regardless, I...

Hey, the current optimal solution would be the one you posted in your update: ```go // goverter:converter type Converter interface { // goverter:mapIdentity A ConvertB(source Input) B // goverter:mapIdentity B...

Sure, but some definitions contradict each other meaning they can't be merged. like the one from above: ```go // goverter:converter type Converter interface { // goverter:mapIdentity B B.A ConvertBase(source Input)...

It doesn't really matter that someone would define it, my point that it is possible. I don't want goverter to be like "if you don't do something stupid it will...

> Did you mean to set the bottom method signature to be something like the following? Yes. > Maybe an option would be to check if there is a handcrafted...

If it would be implemented, it probably should be done similar to how you can add // goverter:map to methods which take a pointer to a struct. See https://github.com/jmattheis/goverter/commit/e921977029a98515cae5188332a3603a339dad06

This is by design. My intention for this is, that when converting from X to Y and back again, then the resulting object should be equal. Example: ```go // goverter:converter...

Please add the models ent.Account and pb.QueryResponse_Account to this issue.