Joshua Marantz

Results 295 comments of Joshua Marantz

oh and there's also system-tests for experiments, including this one: https://github.com/apache/incubator-pagespeed-mod/blob/master/install/apache_experiment_ga_test.sh and there may be others like it in the same directory.

It's possible. Part of the problem might be that mod_pagespeed's server-side cache might be cold at the time that PSI queries the site. Part of what mod_pagespeed caches is the...

TL;DR: only use LoadFromFile on a local physical disk where stat() is cheap. Never use LoadFromFile on a mounted file system. RE stat() overhead per-request: your observation is spot-on, and...

Yes the problem is that Google is no longer officially driving the mod_pagespeed effort, the old download's signature has expired, and the signing infrastructure has evolved. The latest release (1.14)...

I'm concerned about amp-img. I feel like we might not want to rewrite URLs of such images, but only rewrite their content as part of IPRO. The reason is that...

I have not seen this in the wild before. The message comes from here: https://github.com/apache/incubator-pagespeed-mod/blob/7659ff743638781f847e37500b8a7093fb49a2f8/pagespeed/kernel/html/html_parse.cc#L617 This should be a "this cannot happen" kind of scenario, but every once in a...

What do you want to put in for the 'xxxx'? BTW there are some not-well-publicized variations on that ".pagespeed." format to accommodate URL signing and embedded options. I'm not 100%...

I think we might need to update https://www.modpagespeed.com/doc/build_ngx_pagespeed_from_source to point to a download page under Apache rather than https://dl.google.com/dl/page-speed/psol/${NPS_RELEASE_NUMBER}.tar.gz -- Otto what was your thinking about this?

The github repo is open and we would welcome PRs to improve the product. Are you interested? Agreed there is a ton to do.

One thought -- can't remember what the code state is -- if we are using OptimizeForBandwidth for assets, we don't need to include them in the MIN for computing the...