Jeff Manian

Results 22 comments of Jeff Manian

I also asked for input from the Rails team at rails/rails#43634. I thought they might be able to provide some guidance based on how ActiveRecord deals with this in row-level...

Add these to the list of apparent typos: 1. `invalid_post_typ` 1. `missing_post_typ` 1. `request_timeou` 1. Maybe `upgrade_require`? (vs. `upgrade_required`)

I had the same issue @NobodysNightmare mentioned above — the removal of the `callback_url` definition in #70 broke my custom strategies, because the `redirect_uri` during the callback phase does not...

Thanks for your response. We do not use `hiredis`, we just have `redis`. Should I try out `hiredis`, do you think it might help? As I understand it, I can...

It's also worth noting that even in the realm of boolean arithmetic they're not strictly equivalent. Namely the boolean operators will short circuit, and the bitwise operators will not: ```ruby...

I intentionally did not add the option as a request-level parameter, because it would only work on the first request made by each client instance, given that `connection` is reused...

@dblock How would your first option work exactly? Would the block be stored in the config as a proc, and then called with the connection instance during the `::Faraday::Connection.new(endpoint, options)...

I attempted to address a similar issue I was having in #239, but Slack ultimately fixed it for me. Take a look at my comments about `chat.update` and the code...

Regarding your first suggestion: >Would logging the error with complete metadata be more appropriate than throwing it into the error message? I agree — you might be right here, I...

Here's a related idea: I wonder if it would make more sense for each of Slack's error codes to have its own error class. For instance `Slack::Web::Api::Errors::AccountInactive` and `Slack::Web::Api::Errors::NotInChannel`. All...