jman-sketch

Results 11 comments of jman-sketch

Currently, the `add_listener` function is blocking, meaning that page can only be refreshed via the browser itself. However, when navigating using the browser, requests are properly intercepted and modified. I...

It was `driver.get` that was the blocking operation. Added `network.get` for asynchronous navigation

`bidi_network_tests.py` was throwing errors because usage of `|` operator for merging dictionaries was introduced in Python 3.9 while the tests were using 3.8. It has been fixed

All local `chrome-` tests are passing @VietND96 May the workflow be triggered again?

@AutomatedTester I would really appreciate your feedback on this. In particular, what are your thoughts on * Using BiDi objects + websocket vs json + HTTP * Ideally, there should...

Remote tests were timing out due to requesting external URLs. Changing it to internal ones in `pages` solved it

Factored all the repeated functions into `bidi.py` class. Tests are still passing (locally)

@shbenzer Perfect! That explains a lot :confetti_ball:

While adding support for multiple intercepts, noticed that "paused" cached requests are served without waiting for continue request. Not sure if this is intended (from browser end). Since bidi `network.setCacheBehavior`...