Justin Makeig

Results 31 comments of Justin Makeig

Argh. I screwed up the whitespace, so the diff is messier than it should be. I’ll clean this up later and push to this PR.

@Treora, OK, I think I’ve cleaned up my commits, if you want to take a look. I’ll try to put together an HTML test page to exercise the new capabilities...

@Treora, I’ve added [example.html](https://github.com/jmakeig/dom-highlight-range/blob/highlightTemplate/example.html) to illustrate the four options and fixed a few bugs in the early PR (oops!). Please let me know if this works for you.

Thanks for taking a look. All good suggestions. I’ll address these and update the PR (hopefully this weekend). I’d been avoiding ES2015, such as arrow functions, because it looks like...

OK, I think I’ve incorporated your feedback. Let me know how this looks.

jmakeig/dom-highlight-range#1 I can issue a PR against your repo once #2 is merged.

I need to add some tests, but I think #2 adds this capability without changing the existing signature. If you pass it a `string`, it will still create a `span`...

Unfortunately a JavaScript equivalent of `xdmp:spawn-function` will not be available in 8.0-1. It’s something we definitely want to do, but there are some issues with V8 isolation boundaries that make...

@tmcw, I don’t understand how to specify module TOC elements from your reference to `documentation.yml`. The TOC looks like it’s entirely based around classes. In the project I’m documenting, my...