Jenn Magder

Results 611 comments of Jenn Magder
trafficstars

Ignoring the actual numbers, is there any advice in there that's so out-of-date it's probably wrong?

I literally just sent this to a customer 2 weeks ago (which is how I noticed this) :) Most of the info on the page is still useful, it's just...

Another PR pushed it over the timeout as well https://github.com/flutter/flutter/pull/154183. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/13554/infra

Based on the similar issue in https://github.com/flutter/flutter/issues/66647 and the analysis there, it seems this may be related to transactions happening on the background thread. I suspect this will go away...

image_picker_ios is an example in the wild: https://github.com/flutter/packages/blob/a717b0e189ad070a5acb1d0caf4a327c6d222f0c/packages/image_picker/image_picker_ios/ios/image_picker_ios/Sources/image_picker_ios/FLTImagePickerPlugin.m#L180

@hellohuanlin can you help fully fill this out? There shouldn't be any NAs in here, and the validation steps should be filled out.

> ### Cherry pick PR Link > [flutter/engine#54820](https://github.com/flutter/engine/pull/54820) This isn't the right PR link, and this doesn't cherry-pick cleanly due to conflicts with https://github.com/flutter/engine/pull/54335. I'll open a new PR.

The stable PR is open at https://github.com/flutter/engine/pull/55007

> Thanks for the PR @Adam-Langley! We should add a test for this (probably in [code_signing_test.dart](https://github.com/flutter/flutter/blob/ab5b20c16d56c8e608773ce65c3f7c39d515d4a5/packages/flutter_tools/test/general.shard/ios/code_signing_test.dart#L41)). +1 @Adam-Langley it should be relatively easy to add a test around here that...

@Adam-Langley thanks again for your contribution! Will you be able to add the test for this PR? I'm going to mark it as a draft, feel free to mark it...