Jenn Magder

Results 615 comments of Jenn Magder

Hi @ajhemphill91, have you been able to circle back to the requested change for the named constructor? Appreciate your contribution!

@OutdatedGuy thanks for contributing to this! An example of what @stuartmorgan is asking for (sharing between the platforms instead of copying) was done for path_provider and shared_preferences, as he mentioned...

> @jmagman so what should I rename it to? `local_auth_foundation` as in examples you gave or `local_auth_darwin`? I guess `local_auth_darwin`, naming is hard 🙂

~~Heads up some of these classes are being renamed, though I don't see any obvious spots you'll merge conflict https://github.com/flutter/packages/pull/6108~~ Edit well Stuart just said that, missed his comment 🙂

cc @itsjustkevin @CaseyHillers

Okay, never mind, it is codesigned and notarized, and doesn't need the entitlements: ``` $ spctl -a -vvv -t install bin/cache/artifacts/engine/darwin-x64/impellerc bin/cache/artifacts/engine/darwin-x64/impellerc: accepted source=Notarized Developer ID ``` Ran without the...

https://github.com/christopherfujino/codesign.py/pull/3 wasn't correct, it needs to codesign the arm64 iOS framework. @XilaiZhang I'll reopen this to track that the codesign script should reflect master's file list.

It should be codesigned now. On 3.3.4 it is: ``` $ codesign -vvv ./bin/cache/artifacts/engine/darwin-x64/impellerc ./bin/cache/artifacts/engine/darwin-x64/impellerc: valid on disk ./bin/cache/artifacts/engine/darwin-x64/impellerc: satisfies its Designated Requirement $ spctl -a -vvv -t install ./bin/cache/artifacts/engine/darwin-x64/impellerc...

Hm, I'm still not seeing it, I downloaded 3.3.7, ran `/path/to/downloadedflutter/bin/flutter create` then `/path/to/downloadedflutter/bin/flutter run --enable-impeller` on a physical phone, and I didn't see any developer unknown pop up, and...

@Asquare17 or @diver2 were you able to try this? I wasn't able to reproduce this. > Could you open Console, start streaming logs, and reproduce the issue? I would expect...