Joel Lüthi

Results 43 comments of Joel Lüthi

Thanks a lot @normanrz , I am also happy to endorse this RFC! It will be great to get sharding for OME-Zarrs.

> In the case of vizarr, we only load the smallest (lowest resolution) level of the pyramid, and don't load higher resolutions when we zoom in. I think it's awesome...

One additional thought that just came up: Have you profiled the loading pattern once to measure which part slows down the initial loading most? If a lot of time is...

Thanks @ctrueden ! This currently isn't a priority for me, as our production runs on Windows. Just wanted to document the issue for the moment. If I get to check...

Thanks, great idea @will-moore on the `"well_dimensions_not_equal": true` attribute. If the overall approach is something you'd consider in that way, happy to implement that and clean things up a bit...

> From my side, there is definitely an argument for consolidating some metadata at the top-level especially for complex structures like plates. This echoes what was done for the wells...

Hey @joshmoore For this to really work well, we'd need to aggregate some metadata on the sizes of individual wells on the plate level. I now tested it with a...

> But the metadata aggregation could require a spec change, no? Yes, I assume that would require a spec change. So I think a more performant version of this would...

Another small nitpick: The test suite currently generates 270 warnings. Would be good to review if there's anything critical in there

@ajitjohnson This is looking very promising! With the addition of your tests of whole arrays, consider my wish for integration testing covered as well. As mentioned, I mostly wanted to...