Joaquim

Results 29 comments of Joaquim

Great, Ksenia. My initial comments are: - the CI tests don't seem to pass, maybe you can check why is that? It should work. - maybe it would be good...

I am not going to test (yet) this branch on our machines since I see that you are probably going to make some more changes. Also, it seems to me...

Sorry I did not review this yet, I will test compilation/execution tomorrow on our machines. Could you add (e.g. on the folder with test cases) an input file where these...

Compilation works well on our machines. However, when testing this case, `G2V32L1Fi.001.sp,` it does not retrieve the converged equilibrium (force balance ~1e-11) as before. Can you check? Regarding pyspec build,...

For example when I run `G3V02L1Fi.001.sp`, I get this ``` xspech : : version = 3.10 : compiled : date = Thu Oct 21 14:21:54 CEST 2021 ; : :...

Indeed there seems to be something already screwed up in the master branch...this is not good. I don't even understand how the previous versions passed the CI tests, since I...

Antoine and Zhisong, great work and already a first congratulations! @abaillod Regarding the matlab tools, all the check points are very good things to do but we can do that...

`This is also related to #47 as on can start tracing at arbitrary theta based on such a map.` I just want to say that @abaillod has already implemented a...

Thanks Zhisong for opening up this issue. I don't understand how Lconstraint=0 (which presumably fixes mu and fluxes) and LBeltrami=2 (which presumably treats mu as an independent degree of freedom)...

I tested the helicity-fix branch (which compiles and executes) in slab geometry to see what is the Hessian obtained from SPEC in a case where I have the analytical solution...