Jernej Logar

Results 11 comments of Jernej Logar

Hey, not sure where to put this... I tried out Firebird driver with .net core. Everything seems fine. Anything else needed to get those checks ticked? :)

Oh, sorry, was sloppy with that. Was using Windows... Went on to create a repo to make it repeatable. https://github.com/jlogar/FbNetCoreTypeProvider

taking a peek at the code, it would probably make sense to replace occurrences of: `Table.Name.Replace("[","\"").Replace("]","\"").Replace("``","\"")` with a separate function that would optionally (SqlDataProvider static parameter?) quote the table name....

I didn't notice the param in the docs before. Checked it out (http://fsprojects.github.io/SQLProvider/core/odbc.html) and it seems appropriate (apart from the naming :)). Would the approach I mention above and using...

OK, so I finally got around to this again... The first thing I'm trying to do is to run Firebird specific tests so that I can add a test for...

Sure. Here's the first: ``` Executing SQL: EXEC ADD_JOB_HISTORY(101, 13. 01. 1993 00:00:00, 24. 07. 1998 00:00:00, "IT_PROG", 60) - params FirebirdSql.Data.FirebirdClient.FbException (0x80004005): violation of PRIMARY or UNIQUE KEY constraint...

OK, added the delete part. How do you want the PRs organized? I'm not really sure how to avoid the concurrency issue? I'd avoid any locking and with a 100...

Not really sure. Didn't go too far analyzing that part. What I see is a bunch of threads trying to update the same record. They do `HR.GetDataContext()` for each. Not...

OK, I think I got the quotes working. I added a method called getQuotedTableName that is used whenever a table is referenced (not the alias). Also replaced all the duplicated...

@dcneiner Tried it. Seems to work like a charm! Thanks a bunch for the fix! Hope it gets into the master branch soon.