Justin Lanfranchi
Justin Lanfranchi
To start, need to make it clear the intent behind params vs. instantiation args, etc. (outdated docs addressing this are [here](https://github.com/IceCubeOpenSource/pisa/wiki/pipeline_config_format) in the GitHub wiki)
Modifying a param should modify the events accordingly, but reco.resolutions changes the events in a way that doesn't allow this behavior. Either the resolutions changes should be instantiation args (which...
See comment from @steven-j-wren here: https://github.com/jllanfranchi/pisa/pull/394#issuecomment-335250536 In summary: "standard `honda.py` systematics should be included in `mceq.py`. I think this could be as simple as importing them from `honda.py` but I'm...
Unit test `test_Data()` fails due to missing data files. Since I'm in the process of removing test, data, and all but example settings files from the PISA "master" branch (i.e....
originally shows up here: https://github.com/jllanfranchi/pisa/blob/37f168b2d98bd51d8ab90a66c06a80e1a179ef40/pisa/core/events_pi.py#L309-L315 where the np.append was being done, but that will operate on a dict but you can't np.concat dicts. I think whoever wrote this got confused...
Running ```bash export CUDA_VISIBLE_DEVICES=0 export PISA_RESOURCES=/fastio/justin/pisa_resources export PISA_FTYPE=fp32 for t in {1..100} do OUTDIR=/tmp/test${t} $PISA/pisa/scripts/analysis.py discrete_hypo \ --h0-pipeline settings/pipeline/example_mc.cfg \ --h0-param-selections=ih \ --h1-param-selections=nh \ --data-param-selections=nh \ --data-is-mc \ --min-settings settings/minimizer/l-bfgs-b_ftol2e-5_gtol1e-5_eps1e-4_maxiter200.json...
I think we should add `PISA_NUM_THREADS` env var. If `OMP_NUM_THREADS`, 'MKL_NUM_THREADS', and/or `NUMBA_NUM_THREADS` are not defined in the environment, then these should be set in the env to the value...
Tried orders of magnitude; only runs fully with 1e4 events or more. The 1e2 toy events file in pisa_examples now doesn't have enough events for that one to run to...
This appeared in the code with PR #422 from @philippeller, I assume it's from @ts4051 ```python """ ... Parameters ---------- file_type : 'mc' or 'data' """ field_map = copy.deepcopy(self['field_map']) if...
This shows up e.g. when running `test_command_lines.sh` (towards the end). log binning stored in FP32 is loaded with PISA running in FP64, and this fails the check if the bin...