Jeremy Lewi

Results 204 comments of Jeremy Lewi
trafficstars

Update: * I have a draft PR #4148 to port the kfctl E2E test workflow to python. * Once that PR is submitted I can work on using that as...

> If so, user needs to install Tekton CRD in clusters, this may increase user time overhead and complexity, may not be good for user experience. And for some user...

Thanks @iancoffey I think there are a lot of potential integration points between Tekton Triggers and Kubeflow (possibly kubeflow/kfp-tekton#82). We have started to use Tekton to make certain ML tasks...

@xaniasd Do you want to submit a cherry-pick to the 1.0 branch so it will be included in a future RC?

@nrchakradhar I'll need this next week so if you could take a stab at this that would be great. > Create kfctl_go_build_test.py and kfctl_go_deploy_test.py Yes. Although it may be easier...

@nrchakradhar sounds great. I LGTM'd your first PR this morning.

@nrchakradhar How's it going splitting up kfctl_go_test.py into two separate steps? We can split the code into two separate function/modules now. But lets wait until after kubeflow/kubeflow#4148 is merged before...

@r2d4 Is this supported now or is there more work to do?

/cc @lluunn @yanniszark @gabrielwen FYI

I think it would make sense for plugin specs to be versioned as well but should the version be kept in sync KFDef? What should we do in this PR?