Johnnie Birch

Yeah, the flag combination is just not at clear to me and obviously will be dependent and become even less clear when considering the version of emscripten matters. I'm using...

Explicit instructions for AES support are useful but I share the concern/question that it doesn't really fit here. What SIMD instructions are being relaxed here? Don't we expect the same...

/bench_x64

> I think [this secret](https://github.com/bytecodealliance/wasmtime/blob/27435ae398bcce74bf990b9683e5c47c3f6c5d51/.github/workflows/performance.yml#L17) may not be on this repo yet, do you have access to add it or would you like me to add one? @alexcrichton Forked branches...

@alexcrichton I stumbled onto that link as the workflow/action was failing with the same error and I thought the conversation there made sense to apply here. However maybe I am...

> I think this "just" needs to merge #4919, rebase this PR, and try again. > > The `pull_request_review` trigger runs the workflow as-defined on `main`. As-defined on `main` the...

> I used an equivalent token from the account that `PERSONAL_ACCESS_TOKEN` is connected to and I locally ran `git clone ...` and it worked, so I don't think it's token...

> While waiting for the CI runner it says: > > ``` > Job defined at: bytecodealliance/wasmtime/.github/workflows/performance.yml@refs/pull/4928/merge > ``` > > so if it's using the `performance.yml` from the merge...

/bench_x64

> /bench_x64 @alexcrichton This needed to be rebased in order to use the latest yml. I've done that and submitted another test trigger.