Jacob Laursen

Results 226 comments of Jacob Laursen

@cweitkamp - considering the migration to mDNS in Q2/2022, would it be possible to have a look at the few remaining comments from @lolodomo, so we could have this merged...

@clinique - for a PR of this size, perhaps you can add some more context/description to the PR description? Also, without this context, the first question for me would be:...

> We even have a discussion about that and this was my proposal. OK. What about the naming, where does the "OS" come from? > The new binding has many...

> That looks like a good idea. I think the marketplace was not yet existing when we had this discussion with @clinique ;) But in that case, I consider that...

> do you know why some lines are surrounding in dark red in the README ? Syntax error. For example, some JSON has "..." before and after the example, and...

> There seems also to be detected some actual Markdown errors as chapters were refactored, I'll point to one example in separate comment. I thought I saw something, but now...

@alexf2015 - I now went over the remaining files, so only a few comments left to address + checkstyle warnings.

> I fixed most checkstyle warnings. There are a few left which cannot be fixed or I do not understand what's wrong there. I see these: .binding.easee\README.md -- tool |...

> ## org.openhab.binding.easee.internal.handler.EaseeThingHandler.java > tool | priority | line | category | rule | message findbugs | 3 |   | bad practice | Logger should be non-static field (SLF4J) |...

> > ## org.openhab.binding.easee.internal.handler.EaseeThingHandler.java > > tool | priority | line | category | rule | message findbugs | 3 |   | bad practice | Logger should be non-static field...