openhab-addons
openhab-addons copied to clipboard
openhab
[KVV] Replace underlying API
The underlying API does no longer work so it is replaced. An API key is no longer necessary.
Users need to replace the stopId in there station thing configuration. See README.md for details.
@jlaur: do you know why some lines are surrounding in dark red in the README ?
do you know why some lines are surrounding in dark red in the README ?
Syntax error. For example, some JSON has "..." before and after the example, and this is considered a syntax error by the GitHub parser. There seems also to be detected some actual Markdown errors as chapters were refactored, I'll point to one example in separate comment.
There seems also to be detected some actual Markdown errors as chapters were refactored, I'll point to one example in separate comment.
I thought I saw something, but now can't spot anything wrong after those dots.
It is not allowed to create branches on the openHAB repo itself!
Sorry for that! I am part of the openhab organization so I thought it's okay. Should I re-open the PR from a forked repository?
@lolodomo, would you please update the review? The binding is not working right now so I would like to merge the PR asap.
Also the configuration of the binding does not change apart from the removed api-key parameter. I would expect that the configuration is able to handle these kind of parameters that became needless? (regarding backward compatibility)
Also the configuration of the binding does not change apart from the removed api-key parameter. I would expect that the configuration is able to handle these kind of parameters that became needless? (regarding backward compatibility)
As it is a removal, maybe you're right and it will not be a breaking change. Did you check it ? I remove the tag.
Also the configuration of the binding does not change apart from the removed api-key parameter. I would expect that the configuration is able to handle these kind of parameters that became needless? (regarding backward compatibility)
As it is a removal, maybe you're right and it will not be a breaking change. Did you check it ? I remove the tag.
Yes, I tried it. Even with a random parameter that never existed in the context of this binding.
Yes, I tried it. Even with a random parameter that never existed in the context of this binding.
Ok, good.
Just remain 2 comments about adding a "default" XML tag.
It is not allowed to create branches on the openHAB repo itself!
Oh yes, @ne0h , it looks like you created a branch in the openHAB repo rather than creating a branch in your own copy of the openHAB repo !
I would like to finish and merge this PR. @Hilbrand , do you think I will not be able to update and merge the branch ?