John Lane comments

Results 5 comments of


                                            John Lane

For removed items in .patch() first check if exists before deleting

My company uses `dictdiffer` in an internal config management tool. It appeared that the issue was caused by an out-of-sync issue where the config was different from when we read...

For removed items in .patch() first check if exists before deleting

Oh ok that make sense, I think we've figured out what we're going to do about our error. Thanks for looking into it.

Derive screnshot path from details like viewport size, browser and/or a label

From what I can gather, these are your suggestions: 1. Allow runs without baselines to create their own baselines (possibly with optional needle-capture flag) 2. Allow successful runs to generate...

Derive screnshot path from details like viewport size, browser and/or a label

@moellering I started a branch, I've implemented my suggestions a. , b. & c. and I am now moving to your second suggestion. Branch: https://github.com/jlane9/pytest-needle/tree/issue_9

Derive screnshot path from details like viewport size, browser and/or a label

Thanks for the feedback @moellering I've went ahead and made this mode optional (you have to specify using, rather than it being the default). I could someday make each toggleable...