Alex Komoroske

Results 289 issues of Alex Komoroske

See also #550 See the exploration in https://github.com/jkomoros/boardgame/wiki/Representing-spaces The two main things are: 1. Allow configuring a predicate that is run at the last stage of a Board's stack's Move...

Currently keys in Enums are all ints. It's probably more clear to make them `type EnumKey int`, just for clarity. For example, GameDelegate.GroupMembership has to explain in documentation what `map[int]bool`...

https://github.com/wI2L/jsondiff Apparently it's backed by an actual RFC, so maybe it'll be less likely to break as a format

The queries are totally messy and bespoke. https://github.com/huandu/go-sqlbuilder might make it easier to maintain the queries and combine them in code.

As of fixing #633 they're pretty expensive because we redo each one per move, which mainly duplicates the logic. Will get worse after fixing #627

performance

The legal methods are called _constantly_. You can also imagine a number of cases (e.g. an AI searching for moves to apply) where legal would have to be applied very...

Games that use moves.SeatPlayer get much harder to test, you need to fake multiple players. There should be some way to eithe rhave the engine pretend to not do SeatPlayer...