Joel Knighton

Results 16 comments of Joel Knighton

Remove PLRI closeOnException in computeNext

Thanks for the review and additions! I agree on code coverage.

CNDB-13044: Increase MAX_ACCEPTABLE_MEASUREMENT_ERROR in StageTimeMeasurementTest

Multiplexing showed even more flakiness; I'll investigate further and update the PR.

[DRAFT] CNDB-12408 Track memory usage via sensors

Not a review per se, but catching up after today's discussions, and this makes sense to me as a first build to start testing.

CNDB-12240: Allow custom internode outbound metrics

LGTM. Are you also planning to expose InboundConnections' metrics? It seems straightforward enough to do here all at once.

Make it possible for JVector users to consume MemorySegmentReader

@mdogan Thanks for the feedback! We do have cases where it's being used with Java 11 at this time, but I'm very sympathetic to the push to modern JDKs as...

Usage of imprecise fp-model=fast.

Thanks for the pointer, @jbhateja. I'll look into this.