Joel Knighton

Results 10 comments of Joel Knighton

Reviewed the most recent five commits, particularly the CANONICAL filter change. The CANONICAL change resolves all my local reproducers for issues with source Object mismatch when using LIVE sstables containing...

@michaeljmarshall @pkolaczk Git blame suggests you both as reviewers here but feel free to point me elsewhere if you don't have bandwidth.

Michael's comments inspired me to realize that Plan.Intersection and Plan.Union would call `ranges()` if an exception is thrown during execute, returning the empty RangeIterator `ranges` to be closed and leaking...

I'm sympathetic to the goal of deduplicating as early as possible in the read path, particularly because late deduplication obscures other behaviors. I put up an additional PR to test...

> I'm sympathetic to the goal of deduplicating as early as possible in the read path, particularly because late deduplication obscures other behaviors. I put up an additional PR to...

To ease review burden on the large Lucene imports, I am providing the diffs/short summaries of the difference of imported Lucene files (notice about the source will be pushed in...

I've pushed commits addressing all review comments so far. One of the two test failures is flaky and unrelated to this PR. I see the problem and will fix it...

Thank you all for the collaboration and detailed reviews!

@jacek-lewandowski would you mind reviewing here? It looks like you are the primary author of this collection/test. I am also curious if we should remove this test and `valuesStream`. `valuesStream`...

The tension here is between the need to shorten the lifetime of OnHeapGraphIndex views and the GraphIndexBuilder pooling of GraphSearchers, which keep a view for their lifetime. We want GraphIndexBuilders...