Jonathan Kim
Jonathan Kim
Oh yeah thats the first parameter to the permission function. The `user` parameter in `staff_required` is the current user: ```python def staff_required(user, info): if not info.context.user.is_staff: return False return True...
@sliverc is there any reason why you can't use the https://github.com/tfoxy/graphene-django-optimizer library? I'd like to avoid including more code into the library (that needs to be maintained) if there are...
@sliverc I agree that “query explosions” are likely to happen however I think it is a hard problem and one that won’t necessarily be made easier by building an optimiser...
Thanks for the reply @tfoxy . Sounds like you are right @sliverc , we should try and integrate some optimisations into graphene-django so that it is maintainable in the long...
Or @tfoxy if you’d like to merge some of your code into graphene-django that would be very helpful!
OK thanks @sliverc . If anyone else would like to work on adding some optimisations to graphene-django that would be great!
@tfoxy > Would these changes go into v2 or v3? I am not expecting a huge amount of changes needed with v3 since the major breaking change is the dropping...
Just a heads up @tfoxy @mohamedrez that I've had to give up on trying to automatically apply `.only` to all queries: https://github.com/graphql-python/graphene-django/issues/250#issuecomment-518006665 You might find that trying to automatically applying...
@felixmeziere you are right that graphene v3 means that the Promise based dataloader no longer works. This is because graphql-core v3 dropped support for custom backends in favour of using...
@cansin thanks for the detailed error report. This does look like a bug and I'll look into it as soon as possible. As a workaround you can update your `PersonType`...