Jonathan Kim
Jonathan Kim
@tajo there aren't multiple instances of styled-components on the page, it's because our `.ladle/components.tsx` file contains mui components and it seems they get rendered before the `SynchronizeHead` gets mounted. I've...
@tajo any further thoughts on this issue? IMO having an option to disable the `SynchronizeHead` behaviour would be good enough for us because we don't use iframes.
In my testing it didn't disable it because the `CSSStyleSheet` `insertRule` and `removeRule` functions still get patched even if there isn't a `storyWindow`: https://github.com/tajo/ladle/blob/b4d67c149828492e8102206b30eb9522d3176fb8/packages/ladle/lib/app/src/synchronize-head.tsx#L76-L99 Will raise a PR to fix...
> I believe a great way to go forward with this would be to prototype ObjectTypeExtensions and try to re-implement the custom strawberry-django Type as an ObjectTypeExtension with FieldExtensions. There's...
I wonder if it's simpler to just make `Union[Optional[str], UNSET]` work rather than introduce a new type? What do you think @sarahhenkens ? My thinking is that even with a...
Also what should happen if you define `Union[str, UNSET]`. Is that a valid state?
@kevinvalk thats a really good find and it would definitely help the cases with simple async resolvers. However it's worth pointing out that as soon as your resolvers are actually...
@Cito One optimisation that we could make is to never use asyncio.gather when there is only 1 coroutine since it wouldn't provide any benefit. It would help the example in...
I'm not sure why it was setup that way @McPo but I guess the view could handle both kinds of requests. I would expect a client to either always batch...
Makes sense. Sounds like this would be a good enhancement if anyone wants to create a PR.