jkarasti

Results 8 comments of jkarasti

One note to add here: The windows installer could also be localised. https://wixtoolset.org/docs/tools/wixext/wixui/#localization

> I tested with `Scope="perUser"` and I get the following error: > > ![image](https://private-user-images.githubusercontent.com/2507626/370732678-411290e2-301f-4d0e-8c82-17fa782c5d3e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjcyNzYwNDksIm5iZiI6MTcyNzI3NTc0OSwicGF0aCI6Ii8yNTA3NjI2LzM3MDczMjY3OC00MTEyOTBlMi0zMDFmLTRkMGUtOGM4Mi0xN2ZhNzgyYzVkM2UucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkyNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MjVUMTQ0OTA5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjYzMjQ0ZTQwMGM1NmU5MmMzZGRkYThkODc0YWZhNzU4NDVkOGFmZDgyNmNhMjFkYmVjODQ5YWU1NTA0ZjAxYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.UhOWYn7Wj2jA5xEPcw3RGaKo0QmFie8PvV1zqJUl8ic) > > This is similar to this [SO post](https://stackoverflow.com/questions/77839235/wix-how-to-upgrade-per-user-installation-including-services), in which they had to do some...

> ## Should `AllowSameVersionUpgrades="yes"` be removed? > > My understanding is that previously, we specified `*` as the product code: > > https://github.com/freedomofpress/dangerzone/blob/791444cd5dd983f87696c4d16313f2d3a6af515d/install/windows/build-wxs.py#L167 > > With this PR, we don't...

Pushed a couple of changes: #### Removed the `InstallerVersion`. Let's trust the WiX developers keep the default at a sensibly old version of Windows. #### Updated the build instructions. Better...

> Hey @jkarasti. Just wanted to let you know that we have wrapped Dangerzone 0.8.0. If there's something I can take a look at or help you with, now is...

> Just checked the diff between the state of the PR when I reviewed it and its current state. I'm fine with the changes, and the only thing remaining is...

Trying to avoid leaving the Scope issue as is, I took an another deep dive to WiX Toolset `Launch` and `Custom Action` elements. Unfortunately there really doesen't seem to be...

> Just tested [jkarasti:602-upgrade-wix-toolset-fix-regsearch](https://github.com/jkarasti/dangerzone/tree/602-upgrade-wix-toolset-fix-regsearch) and it detected the Dangerzone 0.8.0 installation. However, it doesn't detect previous installations, such as 0.6.0. Our users may skip 0.8.0 for whatever reasons, so we...