Joshua James Venter

Results 28 comments of Joshua James Venter

If you're extending KernelBase, would `do_shutdown` with `restart=False` not satisfy this? https://github.com/ipython/ipykernel/blob/5b4b7a0c07c48742ac17c60cbd2d6a13d09e29c2/ipykernel/kernelbase.py#L996-L1000

Ah, apologies @allefeld. I tried a less involved approach compared to @martinRenou's suggestion. If one can implement `execute_request` and catch the exception of the interpreter: ``` def execute_request(self, stream, ident,...

Is the issue exclusive to `main`? An empty body also compiles and runs: ```mojo fn main(): for i in range(10): ``` Can you reproduce those examples in other contexts outside...

Ah, I agree that the empty body of the `for` is then more likely related to that issue.

`while i > 1:` -> `while i >= 1:` also returns correctly

Hey @bgreni, what's the benefit of making `step` `Optional`?

Going to mark as draft, and wait for `PyObject_GetItem` of #3583 to be merged.

> > Going to mark as draft, and wait for `PyObject_GetItem` of #3583 to be merged. > > #3583 has been merged, so feel free to rebase whenever it's convenient...

> Hey @jjvraw thanks for tackling this, and all your related work in this area recently 🙂 > > I did a quick pass and made a couple of suggestions...

Not sure if this has been worked on internally or not, but a few conflicts came up with #3160 and #3639. Have pushed the changes required.