Jendrik Johannes

Results 275 comments of Jendrik Johannes

Thanks for pointing that out @iherasymenko. IIRC I did it like that with the reasoning that if you patch a Jar that was never intended to be a Module in...

Thanks for the feedback. It is indeed intentional. Do you have suggestion where I could put some more documentation? Inside the build scripts you needed to touch? To explain: -...

Here are my thoughts on the Version Catalog. Took a bit longer, because I still do not have enough experience with it myself to express this in a more compact...

Whatever the issue was, it seems to work with the latest changes which I had not yet published. There is a new version available now - `0.6`. Can you verify...

I remember now that I saw something similar when I did the Kotlin+Modules example I linked above. See readme here: https://github.com/jjohannes/gradle-demos/tree/main/java-17-modules-kotlin#readme I did not have time to follow up on...

We have published a blog post on the topic of how libraries can profit from Gradle Module Metadata and used Guava as an example: https://blog.gradle.org/guava It basically covers what I...

Thanks for taking the time to get back to this @cpovirk. I rebased this PR to latest `master` and addressed both of your comments. Please have a look. From my...

I went ahead and added the integration test as a step to travis to make sure it is working before we merge. Looks good as far a I can tell....

@cpovirk thanks for doing all the cleanup on this PR. Looks like I missed the formatting rules. Very good concern about Android. I did not think of this. We definitely...

Android does not care about the `jvm.version` attribute at all. It only uses two attributes when resolving the classpath: 1. `org.gradle.usage` to distinguish between compile and runtime (this is the...