Jeremy Lin

Results 36 comments of Jeremy Lin

Here's a first cut at base64 support using a derivative of Jouni Malinen's base64 implementation. I started from PR #164, but it's diverged almost completely since then. A few notes:...

@wojtek-oledzki AFAIK, the base64-encoding functionality works fine, and I'm using it myself.

@wojtek-oledzki To clarify what I said about "the producer is not set up for handling this yet", the `kafkacat` producer doesn't support transformations currently, so base64-decoding is not supported yet...

@edenhill Following up since it's been a few months. What would it take to get this merged? Is there anything you want changed in the overall approach?

> I was skeptical about the Apple part. Before i integrate, is this one acceptable: > http://web.mit.edu/freebsd/head/contrib/wpa/src/utils/base64.c > > License under : > http://web.mit.edu/freebsd/head/contrib/wpa/ > 3 claused? @Donis- Any near-term...

Any particular reason you haven't merged this yet? In #68, you wrote: > Doing it in bash seems like a bit of an ugly fix, but I couldn't see a...

Arguably, implicit email verification is how upstream Bitwarden should have done things in the first place. I don't think the goal of Vaultwarden should be making a "bug-for-bug" clone of...

I don't think it's useful to send an email telling a user someone tried registering using their email address. There's generally no specific action they can take in response to...

> > There's generally no specific action they can take in response to that, > > Well, I think this would depend on the message e.g. we could suggest to...

> I would even argue that we cloud remove that random sleep there, and add a rate-limit to it instead. As mentioned in the comments, the sleep is to mitigate...