sslscan icon indicating copy to clipboard operation
sslscan copied to clipboard

Make `sslscan` target non-phony

Open jjlin opened this issue 9 years ago • 2 comments

Since sslscan is a real file, it should be removed from the .PHONY list so that make static install won't try to build a non-static version.

jjlin avatar Mar 17 '16 23:03 jjlin

Any particular reason you haven't merged this yet? In #68, you wrote:

Doing it in bash seems like a bit of an ugly fix, but I couldn't see a nice way to do the check natively in the Makefile

Making sslscan a non-phony target and letting make create that file as necessary is how that check is done natively.

jjlin avatar Mar 31 '16 19:03 jjlin

The sslscan target was originally marked at as pnony in the PR that introduced static building. The problem with marking it as non-phony is that it means that if (for example), you run make, then if you run a make static it will see that sslscan already exists so won't rebuild it (so you'll still have the dynamically build version), which isn't desirible. It's a pain if you have to keep running make clean, because that also blows away the compiled OpenSSL stuff.

I needd to see if there's a nice way to allow both make and make static to work properly with a non-phony sslscan - although I have a feeling it will involve some more ugly bash code :/

~rbsec

rbsec avatar Apr 03 '16 22:04 rbsec