j-j.eth

Results 40 comments of j-j.eth

Seems to be related to https://github.com/substack/factor-bundle/issues/61

So, the solution I have is non-trivial. It involves using a slightly modified fork of `factor-bundle` which emits the output stream for each bundle, and then modifying `grunt-browserify` to use...

@terinjokes would appreciate seeing that example as well.

For those interested, what you really need to know is when all of the `output` streams have `finish`ed. So if `factor-bundle` instead of this: https://github.com/substack/factor-bundle/blob/master/index.js#L94 did ``` javascript Object.keys(pipelines).forEach(function (id,...

FWIW @islemaster, I'm using this _slight_ fork of `factor-bundle` to get the output streams a an extra parameter of the `factor.pipeline` event. https://github.com/justinjmoses/factor-bundle

Sadly I too can't run Phantomjs2 due to some kind of race condition between my initial setup scripts (that setup external browserify deps) and the tests themselves which require those...

@hamxabaig @kayschmitt Phantom2 doesn't work for you? I doubt anyone will patch Phantom 1.9 to support Sierra, so there's not much `karma-phantomjs-launcher` can do to help. @llhupp have you been...

I filed this for Phantom 1.9.8. https://github.com/ariya/phantomjs/issues/14558

FWIW I worked around my particular problem (Phantom 2 upgrade) by ensuring all test bundles (we're using browserify) include all their dependencies rather than externalizing them.

Another workaround for this is using Electron instead of Phantom via https://github.com/lele85/karma-electron-launcher. I managed to upgrade to Phantom 2.1..1 but tried using Electron as a POC and it ran our...