Results 39 comments of Ján

Should this include new linters? We have #291 and #284 pending, both of which are likely to cause a significant number of new errors in most projects. Also, any opinion...

> there were 0 known usages. I think it's used from hh-apidoc, definition-finder, and/or user-documentation But I agree, we should have tests too.

also the AwaitInLoop linter intentionally overrides the default output to print out specific lines but doesn't point to the exact relevant node at each line

I think I'm missing something; in your example `$apple` is only mentioned once so renaming it to `$_apple` should be fine...? Even if you add something like ```hack $apple =...

Oh of course, somehow I missed that `$apple` was used in the foreach loop, sorry. I agree, we should err on the side of excluding any questionable warnings or autofixes,...

This sounds reasonable to me and probably a simple change (possibly just change `ln -sf ...` to `cp ...` in the build script?) but I don't know a lot about...

This repo is just the front page at https://hacklang.org/, isn't it? (every link there goes to docs.hhvm.com or elsewhere) It has 3 hardcoded examples that basically never changed so setting...

Seems reasonable but Fred has stronger opinions about this so I'll leave it to him. Some potential minor concerns: - if we later decided on a different solution and removed...

Looks good to me, but do we need `\var_export` or something similar to ensure special characters are escaped properly? (e.g. `\` in filenames if we ever support Windows, but Unix...

I don't like the distinction between File and Filesystem, why not `File\unlink`? "Everything in File must work with File\Handles" feels like an unnecessary arbitrary restriction to me. > silent stat()...