hhvm-autoload
hhvm-autoload copied to clipboard
hhvm
Export sorted map
Description
Manually generate the exported autoload map in sorted order.
Details
At Slack we commit the vendor autoload map to source control, which makes diffs hard to comprehend given that the map is unordered.
This change replaces the var_export with manually generated code after sorting the arrays so that the generated autoload map should be stable.
CLA
@ssandler requested that I be added to the Slack corporate CLA at some point.
Hi @demmer!
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.
In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Looks good to me, but do we need \var_export or something similar to ensure special characters are escaped properly? (e.g. \ in filenames if we ever support Windows, but Unix filenames can also contain pretty much any character AFAIK).
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!