jjangga0214

Results 130 comments of jjangga0214

@Gocnak @schickling Yes I think I can contribute :) By the way, we are using [`cross-fetch`](https://github.com/lquixada/cross-fetch) under the hood, but it doesn't provide an agent option. So we can consider......

https://github.com/prisma-labs/graphql-request/blob/2c60842a84de120735661f71db827ec3c54ac962/src/index.ts#L84 https://github.com/prisma-labs/graphql-request/blob/2c60842a84de120735661f71db827ec3c54ac962/src/index.ts#L86 https://github.com/prisma-labs/graphql-request/blob/2c60842a84de120735661f71db827ec3c54ac962/src/index.ts#L92-L95 You can override it by `options.headers` or `requestHeaders`. For example, ```ts // Overriding by `options.headers` const client = new GraphQLClient('url', { headers: { 'Content-Type': 'application/json' }, })...

@jasonkuhrt Yes, you're of course right. However, a maintainer can collaborate quite more seamlessly. For example, in #130, I volunteered to take the issue. And I want to respect the...

@davevanfleet > if it's something the maintainers definitely want in a future release This repo is active, but the maintainers do not develop/express priority for the suggested features. They only...

@davevanfleet @Eduardoveras Great. First, how about your creating suggestions on schema of `SubscribePayload` and `SubscribeOptions`? Of course, if our opinions do not converge, you can create distinct PRs anytime, but...

https://github.com/prisma-labs/graphql-request/blob/2c60842a84de120735661f71db827ec3c54ac962/package.json#L50-L52 https://github.com/prisma-labs/graphql-request/blob/2c60842a84de120735661f71db827ec3c54ac962/src/index.ts#L2 `graphql` is a peerDependency, and used in the source code. You have to install it as well. @EliasHjelm The peerDependency is needed on runtime, not a development-only purpose....

This might happen not because of the package, but because of the specific limitation of environments. For example, a server can block a request from a certain IP when it...

@coreyfarrell Thank you for the response! However, it doesn't generate a report properly, in my test. I have a directory like this. ```bash nyc-demo └── coverage-final.json ``` And I run...

@coreyfarrell I found an interesting fact. I made a very simple repo [jjangga0214/nyc-issue-1249-js](https://github.com/jjangga0214/nyc-issue-1249-js), using `jest` and `nyc`. I tested it with `[email protected]` and `[email protected]` (but the repo's package.json only specifies...

@coreyfarrell I just read `nyc`'s docs first time a few days ago. To me, it was unclear that `nyc` can generate reports from coverage.json. For more reader-friendly docs(and for folks...