graphql-request
graphql-request copied to clipboard
jasonkuhrt
Becoming a maintainer
Hi, first, thank you for creating and maintaining graphql-request.
I've been interested in graphql-request as well, thus recently contributed a little bit.
I personally feel this package plays an essential role in the ecosystem, helping many people, and is worth keeping developing.
Can I be a maintainer to collaborate?
Thanks.
@jjangga0214 you can help by sending PRs. We are merging ones that are well done and pass tests. Do you have anything in mind?
@jasonkuhrt Yes, you're of course right. However, a maintainer can collaborate quite more seamlessly. For example, in #130, I volunteered to take the issue. And I want to respect the original author's (@dannycochran) PR, instead of creating a new different PR. To keep work on his branch, I have to create a PR for his PR, which requires him to review and merge. I can wait until my code is completed, and then let him merge, but 'in general', that makes things slow. Because maintainers(e.g. You) on upstream cannot review in real-time. To enable it, I have to create many little PRs against the original author's (@dannycochran in this example) PR, and let him/her review and merge it every time. This is cumbersome.
The same story repeats when any contributor(non-maintainer) wants to work with other contributors.
That is the one point I think beneficial of being a maintainer. How do you think?
Do you have anything in mind?
The most fascinating one is #77. And #193.
I volunteered to take the issue. And I want to respect the original author's (@dannycochran) PR, instead of creating a new different PR
That's a noble goal and I can related having tried to do the same in the past. I think the most practical thing though is to do just that. Would you be ok with that?
Maybe after a certain amount of time enough PRs would make the case for putting you as a maintainer, but no guarantees right now.
@jjangga0214 please feel free to just create a new PR and ignore mine, I think it's fine to do this in the situation where a PR author has abandoned their effort.
